Skip to content

feat: Add bidsignore implementation #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2025

Conversation

effigies
Copy link
Contributor

Builds on #19. Will not try to integrate into the CLI until that's complete.

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.16%. Comparing base (9966ee4) to head (4a3217b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   88.64%   92.16%   +3.52%     
==========================================
  Files           7        9       +2     
  Lines         317      434     +117     
  Branches       35       64      +29     
==========================================
+ Hits          281      400     +119     
+ Misses         22       21       -1     
+ Partials       14       13       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@effigies effigies marked this pull request as draft March 28, 2025 20:21
@effigies effigies force-pushed the enh/bidsignore branch 2 times, most recently from 277c131 to 1f04ab9 Compare April 14, 2025 17:54
@effigies effigies marked this pull request as ready for review April 14, 2025 17:54
@effigies effigies requested review from ubdbra001 and Copilot April 28, 2025 16:46
Copilot

This comment was marked as resolved.

Copy link
Contributor

@ubdbra001 ubdbra001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I understand most of what is happening here, I don't see any thing that looks completely weird, and the test all pass so I'm happy to approve.

@effigies effigies merged commit 7b8b72a into bids-standard:main Apr 30, 2025
25 checks passed
@effigies effigies deleted the enh/bidsignore branch April 30, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants